Make sure to use HttpClient when upgrading the connection for websockets #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using WebSocketClient::begin I got into problems where `status = responseStatusCode();` would be trying to read the HTTP header, but because both HttpClient and WebSocketClient have a read function, the read from WebSocketClient was used, which returns a bunch of gibberish. This caused the WebSocket to think that the connection was not successfully upgraded.
|
|
|
Memory usage change @ 8566fb4
Click for full report table
Click for full report CSV |
|
Hi @per1234 are you still maintaining this project? |
per1234
added
type: imperfection
|
Hi @tim-vandecasteele. Thanks for your pull request! My role in this project is janitorial. I try to help keep the issue tracker tidy and maintain the infrastructure, but am not in a role to decide on changes to the codebase. One of the other maintainers will need to take care of the review and merging of this pull request. |
|
Hi, sorry, I was too quick drawing conclusions from the dependabot merges. Any idea who would be a maintainer for this project then? Looking through the commits there weren't a lot of merges other than these updates in this project. Sorry to bring these questions to you, not really clear who else should be addressed 😅 |
|
Hi @tim-vandecasteele, I would also add ArduinoHttpClient/src/HttpClient.cpp Line 140 in 5c5fafb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disclaimer: I'm a bit puzzled by this problem, as everyone should have this problem but then people would have a lot of problems with websockets
Context: I'm using websockets over https, using
WiFiClientSecureUsing WebSocketClient::begin I got into problems where
status = responseStatusCode();would be trying to read the HTTP header, but because both HttpClient and WebSocketClient have a read function, the read from WebSocketClient was used, which returns a bunch of gibberish bytes. This caused the WebSocket to think that the connection was not successfully upgraded, whereas in reality the webserver gave a proper response.this basically gave
ret = -4, becauseresponseStatusCodecouldn't find the HTTP header.Let me know what the structure is to get things merged, or what adaptations are required.
(I tested this on a simple esp32 board)